Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add security and swagger in inventory #75

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Conversation

khanhduzz
Copy link
Owner

No description provided.

Copy link

sonarcloud bot commented Oct 21, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
24.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link

Sell-bff Coverage Report

Overall Project NaN% NaN% 🍏

There is no coverage information present for the Files changed

Copy link

Inventory Coverage Report

Overall Project 71.93% -23.68% 🍏
Files changed 74.53% 🍏

File Coverage
CorsConfig.java 100% 🍏
SecurityConfig.java 57.89% -42.11% 🍏
SwaggerConfig.java 0%

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 71.42857% with 6 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../java/com/fjb/inventory/config/SecurityConfig.java 66.66% 5 Missing ⚠️
...n/java/com/fjb/inventory/config/SwaggerConfig.java 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files with missing lines Coverage Δ Complexity Δ
...main/java/com/fjb/inventory/config/CorsConfig.java 100.00% <100.00%> (ø) 2.00 <2.00> (?)
...n/java/com/fjb/inventory/config/SwaggerConfig.java 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../java/com/fjb/inventory/config/SecurityConfig.java 66.66% <66.66%> (ø) 5.00 <5.00> (?)

... and 8 files with indirect coverage changes

@khanhduzz khanhduzz merged commit 258410e into main Oct 21, 2024
13 of 14 checks passed
@khanhduzz khanhduzz deleted the add-config-inventory branch October 21, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants